Safe mechanism for converting strings to existing atoms#200
Safe mechanism for converting strings to existing atoms#200macintux wants to merge 2 commits intodevelop-3.0from
Conversation
|
I am leaning more toward #200 than #181 (RIAK-1392) (RIAK-1392) on safety grounds but maybe there's compelling future work that #181 (RIAK-1392) (RIAK-1392) enables I'm missing. Thoughts @seancribbs? |
|
Biased opinion: #181 (RIAK-1392) is safer. If you're allowing a user to create atoms via your config file, you're going to have a bad time. |
|
Addendum: I don't know any case where #181 (RIAK-1392) would break existing schemas. |
|
Realistically, though, how many atoms can you create in a config file (barring active attempt to break the system)? I’m in favor of #181 (RIAK-1392) (RIAK-1392) if I can be convinced it’s harmless, just don’t know how to evaluate that risk for schemas we don’t know about. -John
|
|
It honestly doesn't really matter that much to me; I just don't see how |
Proposed alternative to @seancribbs's #181 (RIAK-1392) that doesn't place existing schemas at risk. Don't allow user input to explode the atom table.